Skip to content

Solarish: missing declaration of port_send and port_sendn #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Solarish: missing declaration of port_send and port_sendn #1655

merged 1 commit into from
Mar 9, 2020

Conversation

batrla
Copy link

@batrla batrla commented Feb 6, 2020

Two functions from Event port framework are missing in libc crate on Solaris. Main functions like port_create, port_associate, port_dissociate, port_get and port_getn are present.

Expected: libc crate on Solaris contains declaration of functions port_send and port_sendn
Actual: libc crate on Solaris is missing declaration of functions port_send and port_sendn

From port_send(3C):

NAME
       port_send,  port_sendn - send a user-defined event to a port or list of ports

SYNOPSIS
       #include <port.h>

       int port_send(int port, int events, void *user);


       int port_sendn(int ports[], int errors[], uint_t nent,
            int events, void *user);

More info:
https://docs.oracle.com/cd/E88353_01/html/E37843/port-send-3c.html

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR here, but right now there's not many maintainers to help merge this, so it may take awhile.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, also could you rebase to check current CI status?

@JohnTitor JohnTitor assigned JohnTitor and unassigned gnzlbg Mar 7, 2020
@batrla
Copy link
Author

batrla commented Mar 9, 2020

all tests green, thanks for fixing CI

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor JohnTitor merged commit bff65e3 into rust-lang:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants