-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable wasm32-unknown-emscripten
target on CI
#1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems emscripten doesn't have |
|
It seems emscripten doesn't have So, I think all items can be removed from emscripten. |
50a6ee0
to
48d7e40
Compare
|
|
b2582e8
to
6d03a43
Compare
Seems |
log:
|
Seems the definition of |
5208fd7
to
8a328ba
Compare
The |
wasm32-unknown-emscripten
targetwasm32-unknown-emscripten
target on CI
Finally, CI is green! |
☔ The latest upstream changes (presumably #1719) made this pull request unmergeable. Please resolve the merge conflicts. |
I don't know a ton about this target myself, but it seems reasonable enough to me. |
Thanks, I think you're familiar with that than me :) Then I'm going to merge this, hopefully, there's no breakage. |
Re-enable the
wasm32-unknown-emscripten
target on CI.Fixes #1591