Skip to content

Add Lockf POSIX to UNIX targets #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add Lockf POSIX to UNIX targets #1708

merged 1 commit into from
Mar 27, 2020

Conversation

pickfire
Copy link
Contributor

@pickfire pickfire commented Mar 25, 2020

Fixes #1631

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pickfire pickfire mentioned this pull request Mar 25, 2020
@pickfire
Copy link
Contributor Author

r? @semarie

@semarie
Copy link
Contributor

semarie commented Mar 25, 2020

about the errors: it seems the constants are already defined for several platforms.
could you try to just keep the lockf function definition ?

please, do not open a new issue, but amend your branch, and push force it (git push --force): it will "update" the current PR.

@pickfire
Copy link
Contributor Author

@semarie I moved it to another branch then it creates a new issue.

@JohnTitor JohnTitor changed the title Lockf Add Lockf Mar 27, 2020
@JohnTitor JohnTitor changed the title Add Lockf Add Lockf POSIX to UNIX targets Mar 27, 2020
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@JohnTitor JohnTitor merged commit bcbfeb5 into rust-lang:master Mar 27, 2020
@pickfire pickfire deleted the lockf branch March 28, 2020 02:03
@Minoru Minoru mentioned this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing POSIX lockf
4 participants