-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add c typedefs for the Sony PSP #1753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The CI failure seems to be spurious, given that this PR does not touch android:
|
The failure should be fixed by #1754, could you rebase? |
Sure, just rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm going to merge but it'd be great if we could add CI for this target like the Nintendo Switch, when you add more items or have time anyway.
Sure, I’ll give it a shot soon. Going to try and get a basic PSP target into rustc first. |
pub const INT_MIN: c_int = -2147483648; | ||
pub const INT_MAX: c_int = 2147483647; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder those constants is needed as you can use c_int::MAX
.
This adds support for PSP targets to build important libraries like
libpanic_unwind
.