Skip to content

Add freebsd nmount #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add freebsd nmount #1939

merged 1 commit into from
Oct 19, 2020

Conversation

DarcInc
Copy link

@DarcInc DarcInc commented Oct 18, 2020

Adding FreeBSD's nmount call to mount devices on filesystems. nmount is preferred over mount.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@JohnTitor
Copy link
Member

Note that CI for FreeBSD 10 is currently broken, it should be fixed in a few days. The change itself looks good, r=me once you squash commits into one or two (nmount and fdatasync) and CI works fine again.

@DarcInc
Copy link
Author

DarcInc commented Oct 19, 2020

Rgr. @JohnTitor Squashed and redelivered.

Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Oct 19, 2020

📌 Commit 16e0a0b has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Oct 19, 2020

⌛ Testing commit 16e0a0b with merge 40e0d54...

@bors
Copy link
Contributor

bors commented Oct 19, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 40e0d54 to master...

@bors bors merged commit 40e0d54 into rust-lang:master Oct 19, 2020
@DarcInc DarcInc deleted the add_freebsd_nmount branch October 20, 2020 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants