Skip to content

Conversation

JohnTitor
Copy link
Member

Fixes #1957
cc @nagisa I think this should resolve the build :)

@rust-highfive
Copy link

@JohnTitor: no appropriate reviewer found, use r? to override

@nagisa
Copy link
Member

nagisa commented Oct 25, 2020

I was going to test it but could not because my test involves -Zbuild-std (and I don't have the time to set up anything else); libstd depends on a specific libc crate version I wasn't able to patch out, so I'll just have to trust my gut and say this LGTM.

@JohnTitor
Copy link
Member Author

@bors r=nagisa

@bors
Copy link
Contributor

bors commented Oct 25, 2020

📌 Commit d371bdc has been approved by nagisa

@bors
Copy link
Contributor

bors commented Oct 25, 2020

⌛ Testing commit d371bdc with merge 2d0d474...

@bors
Copy link
Contributor

bors commented Oct 25, 2020

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: nagisa
Pushing 2d0d474 to master...

@bors bors merged commit 2d0d474 into rust-lang:master Oct 25, 2020
@JohnTitor JohnTitor deleted the fix-dragonfly-build branch October 25, 2020 06:31
@nagisa
Copy link
Member

nagisa commented Oct 25, 2020

Can I have a release with this included so that I could update libstd's libc dependency?

@JohnTitor
Copy link
Member Author

Sure! Opened #1959

@JohnTitor
Copy link
Member Author

Released 0.2.80 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build on dragonfly target with a macro matcher failure
4 participants