Adding dl_iterate_phdr function to uclibc #1967
Conversation
Adding dl_iterate_phdr function and related structs and types to the uclibc module as per the file include/link.h found in the uClibc-ng repository as of version 1.0.36. This is necessary in order for rust to work with a new target armv7-unknown-linux-uclibceabihf.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
The only problem I have is that I couldn't figure out how to cross compile libc-test for the new target |
| // As of uClibc 1.0.36, the following fields are | ||
| // gated behind a "#if 0" block which always evaluates | ||
| // to false. So I'm just commenting these out and if uClibc changes | ||
| // the #if block in the future to include the following fields, these | ||
| // will probably need including here. tsidea |
libc-test for ARM targets needs to be run on qemu via Docker IIRC. You could see some other targets using qemu and Docker. |
|
@bors r+ |
|
📌 Commit f3aab7a has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Adding dl_iterate_phdr function and related structs and types to the
uclibc module as per the file include/link.h found in the uClibc-ng
repository as of version 1.0.36. This is necessary in order for rust to
work with a new target armv7-unknown-linux-uclibceabihf.