-
Notifications
You must be signed in to change notification settings - Fork 1.1k
add CI for armv7-unknown-linux-uclibceabihf #2640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
I don't know that I agree with shellcheck's warning here. I want to split |
LGTM! @bors r+ |
📌 Commit d93b11d has been approved by |
add CI for armv7-unknown-linux-uclibceabihf As discussed in #2636, this is a framework for CI on targets with no prebuilt std. They will build via `nightly` and `-Zbuild-std`, and run the unit tests via qemu-user (or whatever else the dockerfile specifies). It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.
Great! Once this is merged, feel free to @mention me on any CI failures involving uclibc. I'll be happy to help them get resolved. |
💔 Test failed - checks-actions |
CI is also spewing a bunch of errors along the lines "/toolchain/relocate-sdk.sh: 39: file: not found". |
Yeah, I just pushed a fix for that, thanks for the heads up. |
@bors r+ |
📌 Commit bc9e590 has been approved by |
Huh, I don't think bors ran anything for that commit. Did I break it somehow?? |
@bors retry |
@bors r+ |
💡 This pull request was already approved, no need to approve it again.
|
📌 Commit bc9e590 has been approved by |
There seems to have been some issue with the macOS runners in CI. I restarted the jobs and it seems to be working now. |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
As discussed in #2636, this is a framework for CI on targets with no prebuilt std. They will build via
nightly
and-Zbuild-std
, and run the unit tests via qemu-user (or whatever else the dockerfile specifies).It seems like I could write some more documentation about how to add more targets of this type, but perhaps I can get a round of feedback on the mechanism here before I go and write that.