OS X: add various process status tests defined by wait.h #271
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/unix/bsd/apple/mod.rs
Outdated
| status >> 8 | ||
| } | ||
|
|
||
| pub fn WSTATUS(status: ::c_int) -> ::c_int { |
There was a problem hiding this comment.
This doesn't look like it's a #define in sys/wait.h for me, but there's a _WSTATUS, so maybe this is an internal function?
|
Thanks! Just one small nit but otherwise lgtm |
|
Good call. I've pushed a change to rename it to _WSTATUS to match the header, but the obvious other solution here is to just repeat the |
OS X: add various process status tests defined by wait.h Adds the various process test macros specified in the wait(2) manpage on OS X. ```WCOREDUMP``` is implemented BSD-wide as it seems to be the only macro whose definition is constant across the BSDs.
|
☀️ Test successful - status-appveyor, travis |
mqueue: change types to allow more cases Part of nix-rust/nix#270, fixed according to @kamalmarhubi's comments.
Adds the various process test macros specified in the wait(2) manpage on OS X.
WCOREDUMPis implemented BSD-wide as it seems to be the only macro whose definition is constant across the BSDs.