Added SSM sockops for OSes that have support but were missing from libc #2756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) soon. Please see the contribution instructions for more information. |
pfmooney
reviewed
Apr 12, 2022
src/unix/solarish/mod.rs
Outdated
Comment on lines
1773
to
1776
| pub const IP_ADD_SOURCE_MEMBERSHIP: ::c_int = 70; | ||
| pub const IP_DROP_SOURCE_MEMBERSHIP: ::c_int = 71; | ||
| pub const IP_BLOCK_SOURCE: ::c_int = 72; | ||
| pub const IP_UNBLOCK_SOURCE: ::c_int = 73; |
There was a problem hiding this comment.
These are not the correct values for illumos (and presumably Solaris) and cause test failures:
bad IP_ADD_SOURCE_MEMBERSHIP value at byte 0: rust: 70 (0x46) != c 23 (0x17)
bad IP_DROP_SOURCE_MEMBERSHIP value at byte 0: rust: 71 (0x47) != c 24 (0x18)
bad IP_BLOCK_SOURCE value at byte 0: rust: 72 (0x48) != c 21 (0x15)
bad IP_UNBLOCK_SOURCE value at byte 0: rust: 73 (0x49) != c 22 (0x16)
There was a problem hiding this comment.
Thanks, should be fixed now
|
@bors r+ |
|
📌 Commit e7efff4 has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2753