Make utmp(x) support more platforms #353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[cfg_attr(target_os = "macos", link_name = "readdir_r$INODE64")] | ||
| #[cfg_attr(target_os = "netbsd", link_name = "__readdir_r30")] | ||
| pub fn readdir_r(dirp: *mut ::DIR, entry: *mut ::dirent, | ||
| result: *mut *mut ::dirent) -> ::c_int; |
There was a problem hiding this comment.
Despite these being deprecated, we can't remove these due to backwards compatibility, could these stick around for now?
There was a problem hiding this comment.
I decided to ignore them in the tests.
| @@ -350,6 +353,9 @@ fn main() { | |||
| cfg.skip_fn(move |name| { | |||
| // skip those that are manually verified | |||
| match name { | |||
| // glibc-2.24 deprecates these functions | |||
| "readdir_r" | "readdir64_r" => true, | |||
There was a problem hiding this comment.
can these still be tested and the deprecation warning allowed?
There was a problem hiding this comment.
The error message is pasted below.
out/all.c: In function ‘__test_fn_readdir_r’:
out/all.c:2061:17: error: ‘readdir_r’ is deprecated [-Werror=deprecated-declarations]
return readdir_r;
^~~~~~
out/all.c:16:0:
/usr/include/dirent.h:183:12: note: declared here
extern int readdir_r (DIR *__restrict __dirp,
^~~~~~~~~
Perhaps we can pass -Wno-deprecated-declarations to the compiler? Is that acceptable?
|
Got it. It is written in Cargo.lock
|
glibc-2.24 deprecates readdir_r() and readdir64_r()
|
@alexcrichton could be merge now |
|
Awesome, thanks! |
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Cast function item to function pointer in order to appease compiler. This is necessary because of compiler changes. For further information look at rust-lang/rust#19925. This solves rust-lang#346. I know that there are other problems with the affected function. We are thinking about how to best pass the arguments to the function and we don't want to define the ffi's ourselves. However, I would like to get the warning out of our tree as soon as possible. We do not need to wait for our polish.
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
…ang#353) * migrate to rustfmt-preview and require rustfmt to pass * reformat with rustfmt-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ignored deprecated functions
readdir_randreaddir64_rthat fail the tests.