-
Notifications
You must be signed in to change notification settings - Fork 1.1k
OpenBSD: add sendmmsg and recvmmsg support. #3831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
Some changes occurred in OpenBSD module cc @semarie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't pass the test suite under OpenBSD.
cargo:warning=/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c:15544:51: error: must use 'struct' tag to refer to type 'mmsghdr'
cargo:warning= int (*__test_fn_sendmmsg(void))(int, mmsghdr*, unsigned int, int) {
cargo:warning= ^
cargo:warning= struct
cargo:warning=/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c:15549:51: error: must use 'struct' tag to refer to type 'mmsghdr'
cargo:warning= int (*__test_fn_recvmmsg(void))(int, mmsghdr*, unsigned int, int, struct timespec*) {
cargo:warning= ^
cargo:warning= struct
cargo:warning=2 errors generated.
--- stderr
rust version: 1.80.0
error occurred: Command "/usr/local/bin/sccache" "cc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-gdwarf-2" "-fno-omit-frame-pointer" "-m64" "--target=x86_64-unknown-openbsd" "-Wall" "-Wextra" "-Wall" "-Wextra" "-Werror" "-Wno-unused-parameter" "-Wno-type-limits" "-Wno-address-of-packed-member" "-Wno-unknown-warning-option" "-Wno-deprecated-declarations" "-Wno-deprecated-declarations" "-o" "/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/08e68c28a9818392-main.o" "-c" "/data/semarie/repos/rust/build-libc/build/x86_64-unknown-openbsd/debug/build/libc-test-29cac031f36c8215/out/main.c" with args cc did not execute successfully (status code exit status: 1).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now (but getnameinfo break the build)
This is follow up of #3703 |
@@ -1210,6 +1210,7 @@ readlinkat | |||
reallocarray | |||
reboot | |||
recvmsg | |||
recvmmsg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add sendmmsg
and mmsghdr
?
OpenBSD and NetBSD actually seem to have a slightly different signature for This doesn't seem worth special casing on, leaving it |
(backport <rust-lang#3831>) (cherry picked from commit c369185)
close #3696