Add support for Haiku x86 and x86_64

[kallisti5]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[alexcrichton]

Thanks for the PR! Looks like travis is also failing when running the style script.

[alexcrichton]

Can these functions get pushed down into the lower modules instead of adding #[cfg] here?

[alexcrichton]

Can these #[cfg] get pushed down farther instead of being here? (e.g. a b32 and b64 module)

[alexcrichton]

Can this be pushed down to separate modules? Currently we try to keep each module to have at most one invocation of cfg_if! for delegating to sub-modules.

[kallisti5]

I don't really follow the logic there.. If I move all the ifcfg's into something like this:
mod.rs:

use dox::mem;

cfg_if! {
    if #[cfg(target_pointer_width = "64")] {
        mod b64;
    } else {
        mod b32;
    }
}

b32.rs:

pub type c_long = i32;
pub type c_ulong = u32;

const ULONG_SIZE: usize = 32;

Then I begin to get additional style issues:

src/unix/haiku/mod.rs:11 - typedef found after module when it belongs before

[kallisti5]

oh, ok. Move it to the end.

[kallisti5]

Two platforms encountered an error. It sucks having to touch so much unrelated code to add a platform in :-|

arm-linux-androideabi

  Compiling libc v0.2.16 (file:///checkout)
src/unix/notbsd/mod.rs:687:39: 687:46 error: type name `ifaddrs` is undefined or not in scope [E0412]

src/unix/notbsd/mod.rs:687     pub fn getifaddrs(ifap: *mut *mut ifaddrs) -> ::c_int;
                                                                 ^~~~~~~
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/unix/mod.rs:838:1: 862:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:27:9: 27:60 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/lib.rs:264:1: 274:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/unix/notbsd/mod.rs:687:39: 687:46 help: run `rustc --explain E0412` to see a detailed explanation
src/unix/notbsd/mod.rs:687:39: 687:46 help: no candidates by the name of `ifaddrs` found in your project; maybe you misspelled the name or forgot to import an external crate?
src/unix/notbsd/mod.rs:688:34: 688:41 error: type name `ifaddrs` is undefined or not in scope [E0412]
src/unix/notbsd/mod.rs:688     pub fn freeifaddrs(ifa: *mut ifaddrs);
                                                            ^~~~~~~
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/unix/mod.rs:838:1: 862:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:27:9: 27:60 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/lib.rs:264:1: 274:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/unix/notbsd/mod.rs:688:34: 688:41 help: run `rustc --explain E0412` to see a detailed explanation
src/unix/notbsd/mod.rs:688:34: 688:41 help: no candidates by the name of `ifaddrs` found in your project; maybe you misspelled the name or forgot to import an external crate?
error: aborting due to 2 previous errors
Build failed, waiting for other jobs to finish...
error: Could not compile `libc`.

x86_64-unknown-linux-gnu

src/unix/notbsd/mod.rs:687:39: 687:46 error: type name `ifaddrs` is undefined or not in scope [E0412]
src/unix/notbsd/mod.rs:687     pub fn getifaddrs(ifap: *mut *mut ifaddrs) -> ::c_int;

                                                                 ^~~~~~~

src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/unix/mod.rs:838:1: 862:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:27:9: 27:60 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/lib.rs:264:1: 274:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/unix/notbsd/mod.rs:687:39: 687:46 help: no candidates by the name of `ifaddrs` found in your project; maybe you misspelled the name or forgot to import an external crate?
src/unix/notbsd/mod.rs:688:34: 688:41 error: type name `ifaddrs` is undefined or not in scope [E0412]
src/unix/notbsd/mod.rs:688     pub fn freeifaddrs(ifa: *mut ifaddrs);
                                                            ^~~~~~~
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/unix/mod.rs:838:1: 862:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/macros.rs:26:9: 26:76 note: in this expansion of __cfg_if_apply! (defined in src/macros.rs)
src/macros.rs:27:9: 27:60 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/macros.rs:15:9: 19:10 note: in this expansion of __cfg_if_items! (defined in src/macros.rs)
src/lib.rs:264:1: 274:2 note: in this expansion of cfg_if! (defined in src/macros.rs)
src/unix/notbsd/mod.rs:688:34: 688:41 help: no candidates by the name of `ifaddrs` found in your project; maybe you misspelled the name or forgot to import an external crate?
error: Compilation failed, aborting rustdoc

[alexcrichton]

Ah the arguments there likely just need to become ::ifaddrs

[alexcrichton]

Looks like there's still some CI failures?

[kallisti5]

Yeah, same issues. Adding the ::'s didn't have any change.

[alexcrichton]

Oh this was actually in a block that should go away in the sense that these functions don't exist on Android, so you can just push it farther down into the linux-only module.

[kallisti5]

Might want to squash these if accepted :-)

[alexcrichton]

Looks good to me, want to squash?

[avongluck-r1soft]

Github has a new automatic squash.. any issues trying it out? :-D

[alexcrichton]

We actually use @bors here for landing PRs rather than hitting the merge button, and @bors doesn't have the ability to auto-squash commits.

[kallisti5]

Gotcha. I'll squash and resubmit.

I took a crack at bootstrapping and ran into an interesting compiler-rt error:
http://pastebin.com/BVw7dBFN

llvm supports Haiku, so not really sure what's going on there... the error doesn't make sense either.