Skip to content

temporarily define O_DIRECT and SIGINFO for Solaris #4348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

psumbera
Copy link
Contributor

This is temporary fix before new Nix crate version is released. This version will have following commit:
nix-rust/nix@0f45593

The fix is waiting there for new version for several months now. And meanwhile build of Rust on Solaris requires patching.

This should allow proceed with following commit to Rust:
rust-lang/rust#138699

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Mar 21, 2025

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@tgross35
Copy link
Contributor

Would you mind marking the comments FIXME(nix) or FIXME(solaris) or something so we remember to clean them up at some point? Otherwise LGTM.

@psumbera psumbera force-pushed the solaris-tmpfix4nix branch from 92016b0 to 2c408a9 Compare March 22, 2025 13:12
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 22, 2025
@tgross35 tgross35 enabled auto-merge March 22, 2025 13:22
@tgross35 tgross35 force-pushed the solaris-tmpfix4nix branch from 2c408a9 to 141c6d7 Compare March 22, 2025 13:23
@tgross35 tgross35 added this pull request to the merge queue Mar 22, 2025
Merged via the queue into rust-lang:main with commit d252fc6 Mar 22, 2025
43 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-solarish O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants