Skip to content

Update Redox SA_ constants. #4426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

4lDO2
Copy link
Contributor

@4lDO2 4lDO2 commented Apr 21, 2025

Description

Redox completely redesigned its signal handling code last summer, but this wasn't upstreamed to the libc crate, making crates like signal-hook segfault.

It would be appreciated if a 0.2 minor version could be released with these changes.

Closes: #4262

Sources

https://gitlab.redox-os.org/redox-os/relibc/-/blob/master/src/header/signal/redox.rs?ref_type=heads#L43-50

underlying diff

https://gitlab.redox-os.org/redox-os/relibc/-/merge_requests/480/diffs#d174caa1d6ee478ceffe421ab58c6f035a7e7285_72_39

Checklist

@rustbot label +stable-nominated

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-redox O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 21, 2025
@4lDO2 4lDO2 force-pushed the redox-signal-defs branch from f1e5b6d to 74c3cc0 Compare April 25, 2025 12:41
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

@tgross35 tgross35 added this pull request to the merge queue Apr 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 25, 2025
@tgross35 tgross35 added this pull request to the merge queue Apr 25, 2025
Merged via the queue into rust-lang:main with commit 79a9c77 Apr 25, 2025
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-redox O-unix S-waiting-on-author stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants