Skip to content

Fix platform constants not being exposed on mips64el #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

xen0n
Copy link
Contributor

@xen0n xen0n commented Nov 6, 2016

Just noticed this while trying to bring rustup to mips64el, which is almost certainly an oversight.

More work is needed to get rustup working on mips64el, but I'm submitting this first. More fixes to come.

@xen0n
Copy link
Contributor Author

xen0n commented Nov 6, 2016

(I believe the Travis error is spurious, likely a HTTP 503 or 504.)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! I believe though that the target arch is actually mips64 for mips64el-unknown-linux-gnu. Did you find that this fixed compilation failures for you though?

@xen0n
Copy link
Contributor Author

xen0n commented Nov 6, 2016

Oops, I realized immediately that mips64el's arch is also mips64, this is different from mipsel... Hey, the target_arch mipsel itself is bogus, the MIPS32 targets also use mips as target_arch!

(The reason the missing libc constants seemed to not show up was a mistake in overriding deps for Cargo, I believe. I tweaked too many things at once and lost track of what caused what. Closing.)

@xen0n xen0n closed this Nov 6, 2016
@xen0n xen0n deleted the mips64el-oversight branch November 7, 2016 02:50
@xen0n xen0n mentioned this pull request Nov 7, 2016
Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
use tempfile in test_pwrite

Use tempfile in test_pwrite so as not to pollute the source directory.
danielverkamp pushed a commit to danielverkamp/libc that referenced this pull request Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants