Add cfmakeraw and cfsetspeed #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Susurrus
force-pushed
the
more_termios
branch
from
6016bd5 to
e6ac2f1
Compare
|
I think the problem was that the void datatype needed to be explicit in the weird macro in the Android stuff, so hopefully that's fixed. |
Susurrus
force-pushed
the
more_termios
branch
2 times, most recently
from
a108ac1 to
067a9b4
Compare
|
Ugh! I've done that so many times coming from C and I thought it was compiling on my computer. Weird. Anyways, I've updated it. so we'll see how it goes now |
|
Looks like CI may be failing? |
Susurrus
force-pushed
the
more_termios
branch
from
067a9b4 to
045ddfc
Compare
|
Indeed. The macro is picky about void functions still being annotated to return |
Susurrus
force-pushed
the
more_termios
branch
from
045ddfc to
8016339
Compare
This includes implementations for Android.
Susurrus
force-pushed
the
more_termios
branch
from
8016339 to
39e554f
Compare
|
Indeed, got it all sorted out now. |
|
@bors: r+ |
|
📌 Commit 39e554f has been approved by |
bors
added a commit
that referenced
this pull request
Feb 27, 2017
Add cfmakeraw and cfsetspeed This includes implementations for Android. `cfsetspeed` is basically just a back-to-back call to `cfsetispeed` and `cfsetospeed`, both of which seem to do the same thing here, so I just copied that body as well for `cfsetspeed`. The implementation for `cfmakeraw` was taken from the man pages for `termios(3)`.
|
☀️ Test successful - status-appveyor, status-travis |
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
fcntl: Expose FcntlArg variants at the module level This allows importing them directly from `nix::fcntl` which is more ergonomic than needing to use them via `FcntlArg`.
danielverkamp
pushed a commit
to danielverkamp/libc
that referenced
this pull request
Apr 28, 2020
* Add Vector Multiply Add * Add Vector Negative Multiply Subtract * Add Vector Sum Across Partial (1/2) Saturated * Add Vector Sum Across Partial (1/4) Saturated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes implementations for Android.
cfsetspeedis basically just a back-to-back call tocfsetispeedandcfsetospeed, both of which seem to do the same thing here, so I just copied that body as well forcfsetspeed. The implementation forcfmakerawwas taken from the man pages fortermios(3).