Adds many socket related constants #543
Conversation
|
@bors: r+ Nice! |
|
constants like AF_MAX, PF_MAX, NET_RT_MAXID, NET_MAXID, ... aren't intent to be exported as public symbols. As soon a new element is added, the constant will change, and it will requires a major bump for libc. FreeBSD code has comment on that for already included constants that are waiting for libc major crank to be removed. |
|
Changing the values of constants over time should be fine (that's what happens in C after all) but changing the type is what's a breaking change which I don't think changes in these cases? |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@semarie I had noticed that comment in the FreeBSD portion and thought it was limited to just the |
|
📌 Commit 69fb9a2 has been approved by |
|
Just realized I never did AppleBSD. I'll get that working while AWS sorts itself out. |
|
@berkowski is this good to go? I'm planning to send a release bump PR but this looks like it's ready and was just blocked on various outages. Would rather include it than make it wait for another release. Other PRs are significantly less close to done. |
|
@kamalmarhubi Yup, ready to go on my end baring any revisions requested by maintainers. |
|
@bors: r+ Oh oops sorry! |
|
📌 Commit 985ea40 has been approved by |
|
⌛ Testing commit 985ea40 with merge d197e21... |
Adds many socket related constants Started off adding a few constants to help cleaning up some `nix-rust/nix` issues. Went a little.. further. Adds lots of socket-related constants (`PF_*`, `MSG_*`, `AF_*`, `SO_*`, `SOL_*`, etc.) to linux/bsd flavors. Added constants to `bsd/frebsdlike/dragonfly` for completeness, though they aren't covered by CI. Did not touch `notbsd/linux/s390x.rs`
|
☀️ Test successful - status-appveyor, status-travis |
Add support for `smlad` and `smlsd`.
- `smlad`: Dual 16-bit Signed Multiply with Addition and
32-bit accumulation
- `smlsd`: Dual 16-bit Signed Multiply with Subtraction and
32-bit accumulation
Started off adding a few constants to help cleaning up some
nix-rust/nixissues. Went a little.. further.Adds lots of socket-related constants (
PF_*,MSG_*,AF_*,SO_*,SOL_*, etc.) to linux/bsd flavors.Added constants to
bsd/frebsdlike/dragonflyfor completeness, though they aren't covered by CI. Did not touchnotbsd/linux/s390x.rs