Skip to content

Conversation

anatol
Copy link
Contributor

@anatol anatol commented Apr 4, 2017

MINSIGSTKSZ is a minimum size of process stack allowed

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 4, 2017

📌 Commit 0cbdee7 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 4, 2017

⌛ Testing commit 0cbdee7 with merge f030c90...

bors added a commit that referenced this pull request Apr 4, 2017
Add MINSIGSTKSZ constant to linux sources

MINSIGSTKSZ is a minimum size of process stack allowed
@bors
Copy link
Contributor

bors commented Apr 4, 2017

💔 Test failed - status-appveyor

@anatol
Copy link
Contributor Author

anatol commented Apr 4, 2017

nning Install scripts
appveyor DownloadFile https://win.rustup.rs/ -FileName rustup-init.exe
Error downloading remote file: One or more errors occurred.
Inner Exception: The request was aborted: Could not create SSL/TLS secure channel.
Command exited with code 2

Does not look related to my change

@alexcrichton
Copy link
Member

alexcrichton commented Apr 4, 2017 via email

@bors
Copy link
Contributor

bors commented Apr 5, 2017

⌛ Testing commit 0cbdee7 with merge c8b3986...

bors added a commit that referenced this pull request Apr 5, 2017
Add MINSIGSTKSZ constant to linux sources

MINSIGSTKSZ is a minimum size of process stack allowed
@bors
Copy link
Contributor

bors commented Apr 5, 2017

💔 Test failed - status-travis

@anatol
Copy link
Contributor Author

anatol commented Apr 24, 2017

2 powerpc targets fail with following message

RUNNING ALL TESTS
bad MINSIGSTKSZ value at byte 2: rust: 8 (0x8) != c 16 (0x10)
thread 'main' panicked at 'some tests failed', /checkout/target/powerpc-unknown-linux-gnu/debug/build/libc-test-4790929c323c3f02/out/all.rs:11
note: Run with `RUST_BACKTRACE=1` for a backtrace.

could you please help me to understand what does this error mean?

@alexcrichton
Copy link
Member

Oh that just means that the value for the constant is different on powerpc than is what's currently defined. You'll want to update the constant's value on powerpc to fix the message. Right now it's just saying that the value a byte 2 differed, in Rust is was defined as 0x08 and in C it's 0x10

@anatol
Copy link
Contributor Author

anatol commented Apr 24, 2017

I can change it to match the system libc. But it is weird it uses a value different from Linux kernel uapi. The const defined as 2048 there.

MINSIGSTKSZ is a minimum size of process stack allowed
@alexcrichton
Copy link
Member

@bors: r+

Ah looks like it got sorted out

@bors
Copy link
Contributor

bors commented Apr 25, 2017

📌 Commit de75eb6 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 25, 2017

⌛ Testing commit de75eb6 with merge 26b8ab3...

bors added a commit that referenced this pull request Apr 25, 2017
Add MINSIGSTKSZ constant to linux sources

MINSIGSTKSZ is a minimum size of process stack allowed
@bors
Copy link
Contributor

bors commented Apr 25, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 26b8ab3 to master...

@bors bors merged commit de75eb6 into rust-lang:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants