Add pthread_getname_np, requires #define _GNU_SOURCE #789
Conversation
|
Looks great! I think CI has some errors though? |
|
All tests pass on my local machine with the latest Arch Linux. |
|
@dns2utf8 looks like there may still be a lot of CI errors? |
|
☔ The latest upstream changes (presumably #798) made this pull request unmergeable. Please resolve the merge conflicts. |
dns2utf8
force-pushed
the
pthread_setname
branch
from
82495d2 to
1114580
Compare
/usr/include/asm-generic/signal.h 46:#define SIGUNUSED 31 /usr/include/asm/signal.h 56:#define SIGUNUSED 31
|
I am testing it again now. |
|
@alexcrichton regarding the CI errors. Should we switch to a container solution with a more recent linux? |
|
I noticed that the repo already has a CI folder, we could use the scripts or wrap them inside a container. I am currently developing the extension for mac os x. Sadly it broke with the latest updates. |
dns2utf8
force-pushed
the
pthread_setname
branch
from
a333b81 to
7175608
Compare
|
Hi all I finished for the tier 1 plattform. Unfortunatly there is a style violation because android and musl do not support Best |
|
Oh for style I think it can just be tweaked a bit, and for platforms missing this it's ok to just omit the definition on those platforms |
|
☔ The latest upstream changes (presumably #862) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I'm gonna close this now due to inactivity, but it can of course be resubmitted! |
I noticed two things:
pthread_setname_npwas not included in libc so I started adding it.libstd/sys/unix/thread.rsthe linux variantpthread_getname_npis implemented with a raw syscall. So I added it here too.