-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Generate anchors when building instead of using JavaScript #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@azerupi so, two things.
I don't have strong feelings about the second bit, but would prefer to know before I go tweaking a ton of links 😄 /cc @frewsxcv |
I am not sure I understand what you are talking about.
I thought the anchor generation was changed to be the same as GitHub, is that not how rustdoc handles it? How would it differ from now? I don't have strong preferences :) |
Sorry, I meant "development cycles", in another PR you had said school meant you didn't have a ton of time to work on mdbook. I'm trying to make sure I respect your time here :)
in the PR; I made this change, I left a comment next to the algorithm 😄 |
Oh yes indeed, I have a lot of time-consuming projects preventing me to allocate much time to personal projects 😕 But I hope I can find some time here and there to make progress on some long standing issues here, fingers crossed :) |
Great! If you need maintenance help, now that rust is officially using mdbook, @frewsxcv and I might be willing to help, depending. Up to you of course! |
Actually, I have been meaning to talk to you about that :) I am open for whatever would be best :) |
That'd be great! Is there any way you could make it to the next docs meeting? They're wednesdays at 20:00 GMT. Otherwise, we can schedule a specific time 😄 |
Yes, I should be able to join :) It is on IRC right? |
Yes, |
The Rust team uses a linkchecker tool, but since anchors are generated by JavaScript code, it can't check if those anchors are valid.
It would be a better solution to generate anchors when building the book. This would also be a step in the right direction for no-js people too.
rust-lang/rust#39856
The text was updated successfully, but these errors were encountered: