-
Notifications
You must be signed in to change notification settings - Fork 13.3k
linkchecker + mdbook = :frown: #39856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think, but I am not sure anymore, that I implemented it in the JS because it was easier. If there is no other reason, I suppose it would be better to implement this at the generation time. |
It would be better to generate the anchors when generating the HTML. While you're at it, it would be nice if the anchors were generated the same way as rustdoc so links on external websites to the rust docs don't break. |
@ollie27 How are anchors generated by rustdoc? |
That sounds about right, here is the code that does it. |
This has been addressed upstream 🎊 |
/cc @azerupi @rust-lang/docs
Right now, linkchecker reads the HTML of rendered pages directly. It seems that mdBook adds anchors through javascript. This means that linkchecker can't validate links to the book, which is unfortunate.
We could replicate mdBook's logic, but I wonder if that's the best way. Let's figure it out here, and then close this bug out by implementing the solution.
The text was updated successfully, but these errors were encountered: