Skip to content

Avoid triggering search when s is pressed on active input. #2507

Open
@ericholscher

Description

@ericholscher

Problem

We're trying to add a custom search element to mdbook docs, and the default search logic keeps stealing the s key when we try to type it into the search box of our alternate search.

Steps

  1. To go https://test-builds.readthedocs.io/en/mdbook/
  2. Press / to bring up our custom search
  3. Try to type a word with s in it.

Possible Solution(s)

The mdbook search logic should not fire when there is an input element that has focus.

It seems like https://github.com/rust-lang/mdBook/blob/master/src/theme/searcher/searcher.js#L319 should be checking for input types as well as textarea types?

Notes

No response

Version

mdbook v0.4.43

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-SearchArea: SearchC-bugCategory: A bug, incorrect or unintended behavior

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions