Skip to content

something recent broke RBE #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steveklabnik opened this issue Jan 18, 2018 · 4 comments
Closed

something recent broke RBE #553

steveklabnik opened this issue Jan 18, 2018 · 4 comments

Comments

@steveklabnik
Copy link
Member

We render rust by example with the latest mdbook, and today, something is messed up. Look at the code blocks here: https://rustbyexample.com/flow_control/match.html

They're dark black, and impossible to read.

I haven't dug into the details yet, but maybe someone else knows?

@Michael-F-Bryan
Copy link
Contributor

We recently merged a couple CSS/JS changes, so it may be related to one of the recent PRs. Presumably #538 or #535. When you pull up the dev tools console does it mention any scripts or stylesheets returning a 404?

CC: @sorin-davidoi


I don't think I can replicate the issue. The code blocks seem to render normally on my machine.

screenshot_2018-01-18_235110

@sorin-davidoi
Copy link
Contributor

sorin-davidoi commented Jan 18, 2018

Yes, just took a look too but I can't tell what is broken. Can you post some screenshots of how it's supposed to look?

@sorin-davidoi
Copy link
Contributor

Ah, they look like this in Firefox.

image

@sorin-davidoi
Copy link
Contributor

Found the issue:

document.querySelector("[href='ayu-highlight.css']").setAttribute('disabled', true);

does not disable the stylesheet in Firefox, we need to do

document.querySelector("[href='ayu-highlight.css']").disabled = true;

Will open a PR. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants