Fix line-height for footnote-reference #2443
Conversation
…ence, removing inheritance of line height from parent class
src/theme/css/general.css
Outdated
| } | ||
|
|
||
| .footnote-reference{ | ||
| line-height: 0; |
There was a problem hiding this comment.
As far as I understand the standard, this does what you want because a line box's final height is the maximum of the required line-height of all the inline fragment boxes within it. This means, if you set the line-height of something to 0, that element will have no effect on the height of the line.
It's fine, as long as the footnote-reference is never alone on a line. That would be bad typography anyway.
GitHub and rustdoc's CSS both do the exact same thing. You might want to apply this style to all superscripts, not just footnote references.
https://github.com/necolas/normalize.css/blob/master/normalize.css#L128
…t footnote-references.
Ignoring line-height for superscripts
|
What just happened? This didn't get merged, did it? |
|
I'm not sure. I reposted this at #2465. |
ISSUE
#2437 Footnote reference adding some extra vertical space to the line
FIX
Changed general.css file to include custom styling for footnote reference, removing inheritance of line height from parent class.
Tested for various different browsers. (Chrome, Firefox, mobile chrome, mobile firefox)
Before
After