Introduce new testsuite infrastructure #2676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new testsuite intended to replace the other tests, which provides an easy facility to update tests, validate output, and more.
This doesn't exercise *everything* that the old test did, but other tests will take care of those gaps. This is intended as just a smoke test.
…_index to BookTest
…abled_in_config to BookTest
I don't think these exercise anything in particular that aren't necessarily covered by other things. If this ends up exposing a lack of coverage somewhere, I would prefer to add more focused test for specific things.
This helps if you are creating new tests, or debugging existing tests by allowing you to run `mdbook` directly in the test directory to try things out. But we don't want to ever check these files in.
These tests are now all superseded by the new testsuite.
Although there isn't a direct equivalent in the new testsuite, I felt like these weren't adding any specific coverage that the existing tests don't already exercise. If it does turn up that there is specific coverage missing, then I would prefer to have tests which exercise the specific thing of interest rather than have these kinds of non-specific tests.
This was referenced Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new testsuite called
testsuitethat replaces all of the previous integration tests (except for gui). This new testsuite is intended to address a few things:This generally only migrates existing tests, and doesn't really add new ones (other than the extended coverage in each existing test). I expect this to make it easier to add tests in the future to improve coverage. I also expect this to evolve improvements as we gain more experience with it.
Closes #1568