Skip to content

Fixes the search box overlapping with content when first shown #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2018

Conversation

Michael-F-Bryan
Copy link
Contributor

When the sidebar is open and viewing full screen, the empty search box overlaps with page content.

screenshot_2018-04-10_07-13-58

Making the searchbox-outer display as a block element seems to fix the issue.

screenshot_2018-04-10_07-14-52

@Michael-F-Bryan
Copy link
Contributor Author

@steveklabnik once we're happy with this CSS fix regarding search boxes it'll probably be time to do another release.

@Michael-F-Bryan Michael-F-Bryan merged commit 7f82a19 into master Apr 10, 2018
@Michael-F-Bryan
Copy link
Contributor Author

Michael-F-Bryan commented Apr 11, 2018

I've just tried to use mdbook at work (Firefox on Windows) and it looks like this "fix" only works for chrome. Back to the drawing board then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant