Implement better error handling #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleywiser
commented
Apr 9, 2019
| // TODO: This is very crude error handling. | ||
| // https://github.com/rust-lang/measureme/issues/9 | ||
| fs::create_dir_all(path.parent().unwrap()).unwrap(); | ||
| fn from_path(path: &Path) -> Result<Self, Box<Error>> { |
There was a problem hiding this comment.
Is Box<Error> ok or should we use a better error type?
wesleywiser
force-pushed
the
error_handling
branch
from
9a5e7c2 to
bfa1421
Compare
Closed
michaelwoerister
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
r? @michaelwoerister