summarize: Don't panic on broken pipe #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hit rust-lang#31 while piping summarize to head. The original issue was in part due to `prettytable` panicking. That's since been upgraded to a version with the fix, but some of the `println!`s that happen after `table.printstd()` will also panic from the broken pipe: $ summarize summarize ... | head ... thread 'main' panicked at library/std/src/io/stdio.rs:1165:9: failed printing to stdout: Broken pipe (os error 32) note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace To fix this, change the `println!`s to `writeln!`s, and ignore any errors. Fixes rust-lang#31.
bjorn3
reviewed
Jun 24, 2025
summarize/src/main.rs
Outdated
| @@ -142,7 +142,11 @@ fn diff(opt: DiffOpt) -> Result<(), Box<dyn Error + Send + Sync>> { | |||
|
|
|||
| table.printstd(); | |||
|
|
|||
| println!("Total cpu time: {:?}", results.total_time); | |||
| _ = writeln!( | |||
There was a problem hiding this comment.
I think you should just exit the process on a broken pipe rather than keep writing data to nowhere.
There was a problem hiding this comment.
Makes sense -- implemented a catch-all "exit on failure" in 59876d9.
Do you think it should special-case broken pipe to return a visible error otherwise? or better to just give up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit #31 while piping summarize to head. The original issue was in part due to
prettytablepanicking. That's since been upgraded to a version with the fix, but some of theprintln!s that happen aftertable.printstd()will also panic from the broken pipe:To fix this, change the
println!s towriteln!s, and ignore any errors.Fixes #31.