Skip to content

Split pass and pass-dep tests #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Jul 25, 2022 · 0 comments · Fixed by #2448
Closed

Split pass and pass-dep tests #2442

RalfJung opened this issue Jul 25, 2022 · 0 comments · Fixed by #2448
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

Currently, some pretty fancy cargo-miri machinery needs to work to even run the most basic 'pass' tests. That seems unnecessary fragile. We should move the 'pass' tests that need external dependencies into a separate test suite like 'pass-dep', and run the 'pass' test suite first without any attempt at building dependencies.
@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-tests Area: affects our test suite or CI labels Jul 25, 2022
@oli-obk oli-obk mentioned this issue Jul 27, 2022
Merged
@bors bors closed this as completed in d095429 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tests Area: affects our test suite or CI C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run pass tests without building dependencies first oli-obk/miri
1 participant
@RalfJung