Skip to content

Run pass tests without building dependencies first #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jul 27, 2022

fixes #2442

One thing that I'm wondering is if we should do away with running each folder individually and make ui_test support running all tests in parallel (so building deps becomes a thread, and all tests needing deps are blocked on it)

@RalfJung
Copy link
Member

One thing that I'm wondering is if we should do away with running each folder individually and make ui_test support running all tests in parallel

Oh yeah that is neat. Something for the future. :)

@bors
Copy link
Contributor

bors commented Aug 2, 2022

☔ The latest upstream changes (presumably #2457) made this pull request unmergeable. Please resolve the merge conflicts.

@RalfJung
Copy link
Member

RalfJung commented Aug 3, 2022

@rustbot author

@rustbot rustbot added the S-waiting-on-author Status: Waiting for the PR author to address review comments label Aug 3, 2022
@oli-obk oli-obk force-pushed the test_crates_on_their_own branch from 3ab28fe to 9851578 Compare August 24, 2022 13:32
@oli-obk
Copy link
Contributor Author

oli-obk commented Aug 24, 2022

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Waiting for a review to complete and removed S-waiting-on-author Status: Waiting for the PR author to address review comments labels Aug 24, 2022
@oli-obk oli-obk force-pushed the test_crates_on_their_own branch from 9851578 to f48a0a8 Compare August 25, 2022 08:01
@oli-obk oli-obk force-pushed the test_crates_on_their_own branch from f48a0a8 to 6f8885e Compare August 25, 2022 08:03
@RalfJung
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 25, 2022

📌 Commit 6f8885e has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 25, 2022

⌛ Testing commit 6f8885e with merge d095429...

@bors
Copy link
Contributor

bors commented Aug 25, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d095429 to master...

@bors bors merged commit d095429 into rust-lang:master Aug 25, 2022
@oli-obk oli-obk deleted the test_crates_on_their_own branch October 4, 2022 13:46
@oli-obk oli-obk restored the test_crates_on_their_own branch January 27, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split pass and pass-dep tests
4 participants