Skip to content

Conversation

niluxv
Copy link
Contributor

@niluxv niluxv commented Aug 22, 2021

Add support for the unstable volatile_set_memory intrinsic

(Runtime behaviour and soundness requirements for volatile_set_memory are identical to those of write_bytes, so supporting this intrinsic is trivial.)

Runtime behaviour and soundness requirements are identical to `write_bytes`.
@RalfJung
Copy link
Member

Thanks for the PR!

Could you extend the tests in tests/run-pass/write-bytes.rs to also call the new intrinsic?

@niluxv
Copy link
Contributor Author

niluxv commented Aug 23, 2021

I wonder whether volatile.rs is a better location or not (on the one hand it already has #![feature(core_intrinsics)], but on the other hand the test can be nearly identical to the tests already in write-bytes.rs)... ?

@RalfJung
Copy link
Member

Hm, good point... no strong opinion.

@RalfJung
Copy link
Member

This seems fine for now though. Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 23, 2021

📌 Commit 083e5e6 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented Aug 23, 2021

⌛ Testing commit 083e5e6 with merge 94ae910...

@bors
Copy link
Contributor

bors commented Aug 23, 2021

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 94ae910 to master...

@bors bors merged commit 94ae910 into rust-lang:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants