add test for backtrace with global allocator #2177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm amazed a ui test like this passes CI without anything else needed 😆 Should we clean up the old code path for previous versions of Backtrace now? Or did all of that already happen? |
RalfJung
reviewed
Jun 2, 2022
| use std::backtrace::Backtrace; | ||
|
|
||
| #[global_allocator] | ||
| static GLOBAL_ALLOCATOR: System = System; |
There was a problem hiding this comment.
So even using the System allocator failed before?
There was a problem hiding this comment.
Ah yes, we distinguish C allocations from Rust allocations. Makes sense.
|
Thanks! :)
We could remove support for v0 of the API, yeah. No strong opinion on that. |
|
📌 Commit 0b7a148 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1996