Add unix helpers #2226
Merged
Add unix helpers #2226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Jun 11, 2022
bjorn3
reviewed
Jun 11, 2022
RalfJung
reviewed
Jun 11, 2022
RalfJung
reviewed
Jun 11, 2022
ghost
force-pushed
the
unix-helpers
branch
2 times, most recently
from
615550f to
5d72669
Compare
|
This looks good! However, please rebase the PR on top of current master and also use assert_target_os_is_unix for getpid. |
ghost
force-pushed
the
unix-helpers
branch
2 times, most recently
from
0fa19df to
f747cd8
Compare
ghost
changed the title
|
@bors r+ |
|
📌 Commit bc27fbb has been approved by |
|
☀️ Test successful - checks-actions |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates unix helper(s)