Clarify the effect of the -Zmiri-track-pointer-tag flag in the README
#2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to explicitly say it also tracks tag creation
RalfJung
reviewed
Jul 3, 2022
|
Ah, good point. I think we added a message on tag creation at some point and forgot to update the docs. I tried to clarify that not seeing invalidation can be perfectly normal by adding "(if ever)", do you think that helps? |
Co-authored-by: Ralf Jung <[email protected]>
|
Yes, definitely! Thanks again for being on top of this, I added a commit with your suggestion. |
|
Thanks for helping improved our docs! |
|
📌 Commit 1b9e19a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the README to explicitly say that the
-Zmiri-track-pointer-tagflag also tracks the creation of tags, not just when they are popped/invalidated.Related to #2308 / Manishearth/triomphe#38.