Use Vec's binary search instead of hand-written one. #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Aug 9, 2023
| // We are too far right (offset is further left). | ||
| debug_assert!(candidate < right); // we are making progress | ||
| right = candidate; | ||
| std::cmp::Ordering::Greater |
There was a problem hiding this comment.
Please preserve the comments inside the ifs here, they still seem helpful.
Also have the comment explain that Greater indicates "elem is greater than desired target".
RalfJung
reviewed
Aug 9, 2023
|
Thanks, this looks much cleaner! @bors r+ |
|
☀️ Test successful - checks-actions |
ttsugriy
added a commit
to ttsugriy/miri
that referenced
this pull request
Aug 16, 2023
It's similar to rust-lang#3021 and should improve maintainability.
ttsugriy
added a commit
to ttsugriy/miri
that referenced
this pull request
Aug 16, 2023
It's similar to rust-lang#3021 and should improve maintainability.
bors
added a commit
that referenced
this pull request
Aug 16, 2023
Replace hand-written binary search with Vec::binary_search_by. It's similar to #3021 and should improve maintainability.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 17, 2023
It's similar to rust-lang/miri#3021 and should improve maintainability.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 17, 2023
…Jung Replace hand-written binary search with Vec::binary_search_by. It's similar to rust-lang/miri#3021 and should improve maintainability.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
…Jung Replace hand-written binary search with Vec::binary_search_by. It's similar to rust-lang/miri#3021 and should improve maintainability.
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
…Jung Replace hand-written binary search with Vec::binary_search_by. It's similar to rust-lang/miri#3021 and should improve maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.