add 'project' process guidlines for larger contributions #3807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only disagreement I had with you on the issue was whether this guidance would have prevented a past problem. I think the project process or guidelines as you've laid them out are good. I'm quite happy with the wording here. |
oli-obk
approved these changes
Aug 17, 2024
There was a problem hiding this comment.
This is general good advice. I don't think it has the necessary requirements to get us enough information to avoid many issues before implementing things (doing it thoroughly would be akin to experimental implementation so it would be effort and not give us an advantage), but it will give everything some structure and help us understand where individual PRs belong in a larger picture.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3443
I am honestly not entirely sure what the consensus from what issue was. I feel like the epoll PR worked reasonably well, and not having been closely involved I am not sure which process @oli-obk followed there. Compared to the first draft in #3443 I tried to make this less formal and framed more as guidelines than hard rules.