Use host's rng when communication is enabled #914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
requested changes
Aug 20, 2019
|
@bors r+ lgtm then |
|
📌 Commit b44fd97 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 20, 2019
Use host's rng when communication is enabled This uses the host's randomness when the communication enabled flag is used. I am not sure about the error handling. I was thinking about fallbacking to `rand` if `getrandom` fails and also print something so the user knows miri is not using the host's rng because it failed. Let me know what you think. Related issue: #800. r? @RalfJung @oli-obk
RalfJung
reviewed
Aug 20, 2019
|
Also could you expand the |
Sure |
|
@bors r- retry |
RalfJung
reviewed
Aug 20, 2019
RalfJung
reviewed
Aug 20, 2019
|
Thanks! @bors r+ |
|
📌 Commit f53b5b0 has been approved by |
bors
added a commit
that referenced
this pull request
Aug 23, 2019
Use host's rng when communication is enabled This uses the host's randomness when the communication enabled flag is used. I am not sure about the error handling. I was thinking about fallbacking to `rand` if `getrandom` fails and also print something so the user knows miri is not using the host's rng because it failed. Let me know what you think. Related issue: #800. r? @RalfJung @oli-obk
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the host's randomness when the communication enabled flag is used. I am not sure about the error handling. I was thinking about fallbacking to
randifgetrandomfails and also print something so the user knows miri is not using the host's rng because it failed. Let me know what you think.Related issue: #800.
r? @RalfJung @oli-obk