Check that fs errors have the proper kind #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2019
|
Thanks! @bors r+ |
|
📌 Commit 3085851 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 13, 2019
Check that fs errors have the proper kind r? @RalfJung
|
💔 Test failed - checks-travis |
|
A new compiletest-rs was released and needs a newer rustc (and we can't have a lockfile unfortunately)... I'm on it. (EDIT: #994) |
Closed
|
Now with a lockfile, this should works. @bors r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 3085851 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 14, 2019
Check that fs errors have the proper kind r? @RalfJung
|
💔 Test failed - checks-travis |
|
Looks like a legitimate test failure... Did these tests pass locally for you?
|
|
oh sorry I had done those before you changed the test to use `&path` so I rebased without testing... my bad. Let me fix it
…-------- Original Message --------
On Oct 14, 2019, 04:07, Ralf Jung wrote:
Looks like a legitimate test failure... Did these tests pass locally for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#992?email_source=notifications&email_token=AHSUMUF3S3TPF24SWPTZDWDQOQZDRA5CNFSM4JAIL3PKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBD2NYQ#issuecomment-541566690), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHSUMUBIFZUXFAORNK24WQDQOQZDRANCNFSM4JAIL3PA).
|
pvdrz
force-pushed
the
check-errno-value
branch
from
3085851 to
0ac9be6
Compare
RalfJung
reviewed
Oct 14, 2019
RalfJung
reviewed
Oct 14, 2019
pvdrz
force-pushed
the
check-errno-value
branch
from
0ac9be6 to
f425f44
Compare
|
@bors r+ |
|
📌 Commit f425f44 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 14, 2019
Check that fs errors have the proper kind r? @RalfJung
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @RalfJung