Introducing init/uninit before its use #355
Merged
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case, I believe the meaning is intuitive enough that the abbreviation makes sens. However, I still prefer to introduce it explicitly. In particular because, in drop-flags, I misintepreted "x was uninit". I thought that "uninit" was a verb, so that something did uninit x. It is only after some thought that I understood that it was not a passive sentence but a descriptive one, and that "uninit" should be understood as an adjective.
JohnTitor
approved these changes
May 7, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2022
Update books ## nomicon 9 commits in c7d8467ca9158da58ef295ae65dbf00a308752d9..10d40c59a581c66d8ecd29ad18d410bf97ed524d 2022-04-06 14:26:54 +0900 to 2022-05-07 10:45:07 +0900 - Introducing init/uninit before its use (rust-lang/nomicon#355) - Change will to would to discuss what don't occur (rust-lang/nomicon#361) - State that pop for length 1 is an example (rust-lang/nomicon#360) - Correct a sentence that didn't seem to be proper (rust-lang/nomicon#358) - Indicate that C reference are C reference (rust-lang/nomicon#357) - Introduce and avoid dropck (rust-lang/nomicon#353) - Rephrase improperly reduced borrows introduction (rust-lang/nomicon#352) - Two lifetime clarification (rust-lang/nomicon#350) - "UB" vs "Undefined Behavior" (rust-lang/nomicon#349) ## reference 9 commits in b5f6c2362baf932db9440fbfcb509b309237ee85..8e36971959ff238b5aa2575fbc7a2e09e1313e82 2022-04-10 19:19:51 -0700 to 2022-05-09 17:20:59 -0700 - Stop saying that const functions cannot use 'extern' (rust-lang/reference#1207) - Moved the option variant imports (rust-lang/reference#1208) - #[must_use] on traits also affects trait objects (rust-lang/reference#1203) - Don't use PathPattern in RangePattern bounds (rust-lang/reference#1204) - Inline assembly: Add kreg0 register class (rust-lang/reference#1205) - Fix crate_type attribute examples (rust-lang/reference#1201) - Say that that the default function return type is the unit type (rust-lang/reference#1199) - Clarify guarantees provided by repr(packed) (rust-lang/reference#1163) - Document the Termination trait for main() and test functions (rust-lang/reference#1194) ## book 43 commits in de0dbffc5812fd885700874e8d258dd334733ac4..d9415b7cbfcb4b24062683f429bd0ff535396362 2022-04-18 19:29:45 -0400 to 2022-05-09 09:10:44 -0400 - Update ch09-02-recoverable-errors-with-result.md - Added missing be 2 - Added missing be - Move hardcoded string into status_line to be consistent - Fix trailing space - Propagate tech review edits back to src - Change "semantics" to "mechanics"; when referring to compiler behavior, rather than syntax. - Propagate some edits to ch4 snapshot - Suggestions from tech review - Propagate edits to src - Propagate edits back to nostarch version - Clarify sentences about lock types. Fixes rust-lang/book#2937. - Edits to edits to chapter 16 - Edits from nostarch for chapter 16 - Propagate nostarch edits back to src - Add words to dictionary - Propagating edits back to the nostarch snapshot - Small wording change. Fixes rust-lang/book#3112. - Clarify the kind of manual cleanup meant here - Edits to edits to chapter 15 - Edits from nostarch - Add missing word - Improve sentence structure - fix unidiomatic new functions in chapter 15 - Propagate nostarch ch14 to src - Update a link and the -p publishing instructions - Actually, I don't think we need to show the command output here - Edits to edits to chapter 14 - Update manual regeneration instructions - Reflect the addition of the -p flag in Cargo 1.56 in chapter 14 - Change polarity and names of variables in env var section - Propagate nostarch edits back to ch 12 - Change environment variable and field name to perhaps be less confusing - Responses to nostarch edits - Merge remote-tracking branch 'origin/ch13' - Fix rust-lang/book#3002 use noplayground with common.rs - Propagate ch3 edits to src - Updating chapter 3 to use new println style - Specify loop label format. Fixes rust-lang/book#3105. - Clarify function definition must be in an accessible scope. Fixes rust-lang/book#3003 - Addressing tech review comments, propagating other changes - Comments from tech review - Chapter 3, section 2 - Add explicit type annotation to example of scalar type char. ## rust-by-example 6 commits in 44a80e8d8bfc5881c9bd69a2cb3a570776ee4181..e9f93cfcf410bc092c9107b8a41a82f144c761f2 2022-04-19 07:46:28 -0300 to 2022-05-08 18:24:06 -0300 - Add empty slice example (rust-lang/rust-by-example#1538) - Enhancement/print (rust-lang/rust-by-example#1536) - Update cast.md (rust-lang/rust-by-example#1521) - Update iter_any.md (rust-lang/rust-by-example#1522) - Update tuples.md (rust-lang/rust-by-example#1524) - fix indent in fs.md (rust-lang/rust-by-example#1535) ## rustc-dev-guide 8 commits in 043e60f..0c02acd 2022-04-20 18:57:49 +0900 to 2022-05-10 09:45:31 -0300 - Update overview.md (rust-lang/rustc-dev-guide#1351) - Update date references on parallel-rustc (rust-lang/rustc-dev-guide#1348) - mention `WithOptConstParam` (rust-lang/rustc-dev-guide#1346) - Fix format (rust-lang/rustc-dev-guide#1349) - correct type of SubstsRef (rust-lang/rustc-dev-guide#1347) - Document ErrorGuaranteed (rust-lang/rustc-dev-guide#1316) - Edit "What the compiler does to your code" (rust-lang/rustc-dev-guide#1306) - Update some date refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case, I believe the meaning is intuitive enough that the abbreviation
makes sens. However, I still prefer to introduce it explicitly. In particular
because, in drop-flags, I misintepreted "x was uninit". I thought that "uninit"
was a verb, so that something did uninit x. It is only after some thought that I
understood that it was not a passive sentence but a descriptive one, and that
"uninit" should be understood as an adjective.