Skip to content

Deprecate unsafe pin projection macros #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Deprecate unsafe pin projection macros #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/projection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@
///
/// [`Unpin`]: core::marker::Unpin
/// [`drop`]: Drop::drop
#[deprecated(
since = "0.1.1",
note = "this macro is not safe; use pin-project or pin-project-lite crate instead"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to add links to both crates here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding two links is a bit noisy, so it's probably OK as is.

)]
#[macro_export]
macro_rules! unsafe_pinned {
($f:tt: $t:ty) => {
Expand Down Expand Up @@ -81,6 +85,10 @@ macro_rules! unsafe_pinned {
/// avoid consuming the [`Pin`].
///
/// [`Pin`]: core::pin::Pin
#[deprecated(
since = "0.1.1",
note = "this macro is not safe; use pin-project or pin-project-lite crate instead"
)]
#[macro_export]
macro_rules! unsafe_unpinned {
($f:tt: $t:ty) => {
Expand Down
2 changes: 2 additions & 0 deletions tests/projection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
#![allow(deprecated)]

use pin_utils::{pin_mut, unsafe_pinned, unsafe_unpinned};
use std::marker::Unpin;
use std::pin::Pin;
Expand Down