Skip to content

Clarify majority/consensus criteria #258

Closed
@dwijnand

Description

@dwijnand

As of #188, the current FCP proposed comment says "Once a majority of reviewers approve (and none object)" and the conditions are num_active_concerns == 0 && num_outstanding_reviews < num_complete_reviews && num_outstanding_reviews < 3.

In an proposal in cargo, the contributor thought it was strict majority: rust-lang/cargo#6535 (comment).

Could the messaging be improved?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions