Skip to content

RFC: #[cfg(accessible(..) / version(..))] #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Sep 26, 2019
Merged

RFC: #[cfg(accessible(..) / version(..))] #2523

merged 50 commits into from
Sep 26, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 12, 2018 •
edited
Loading

🖼️ Rendered

⏭ Tracking issue (#[cfg(version(..))]

⏭ Tracking issue (#[cfg(accessible(..))]

📝 Summary

Permit users to #[cfg(..)] on whether:

  • they have a certain minimum Rust version (#[cfg(version(1.27))]).
  • a certain external path is accessible (#[cfg(accessible(::std::mem::ManuallyDrop))]).

💖 Thanks

To @eddyb, @rpjohnst, @kennytm, @aturon, and @rkruppe for discussing the feature with me.
To @Mark-Simulacrum, @MajorBreakfast, @alexreg, @alercah, and @joshtriplett for reviewing the draft version of this RFC.

Centril added 26 commits August 10, 2018 15:09
@Centril
rfc, cfg-path-version: initial version.
ab8d6b3
@Centril
rfc, cfg-path-version: fix unbalanced parens.
4670370
@Centril
rfc, cfg-path-version: fix typo.
e0f0fea
@Centril
rfc, cfg-path-version: fix incorrect summary.
d564d75
@Centril
rfc, cfg-path-version: fix typos.
091e470
@Centril
rfc, cfg-path-version: use semver caret requirements.
8477b57
@Centril
rfc, cfg-path-version: bnf consistency.
d44a484
@Centril
rfc, cfg-path-version: use version = '..' and motivate it.
c06eb95
@Centril
rfc, cfg-path-version: define 'nightly' in terms of #![feature(..)]
eb3ec27
@Centril
rfc, cfg-path-version: note that path_exists only sees public things …
65dd139 
…as existing.
@Centril
rfc, cfg-path-version: use path_exists = '..'.
144ff93
@Centril
rfc, cfg-path-version: note on canary builds.
13bdfac
@Centril
rfc, cfg-path-version: meta grammar changes..
c54db7f
@Centril
rfc, cfg-path-version: optional dependencies are out of scope.
a5f69b9
@Centril
rfc, cfg-path-version: note use case of working around compiler bugs.
8832ea4
@Centril
rfc, cfg-path-version: talk about the lint.
fb30214
@Centril
rfc, cfg-path-version: crater stuff not a drawback.
7201651
@Centril
rfc, cfg-path-version: clarify re. old versions using this.
2fce9e6
@Centril
rfc, cfg-path-version: implementation questions re. path_exists.
fdf3ed7
@Centril
rfc, cfg-path-version: justify meta grammar changes.
6442367
@Centril
rfc, cfg-path-version: justify preventing relative paths.
de60af4
@Centril
rfc, cfg-path-version: justify nightly instead of if_possible_feature.
72ee5fa
@Centril
rfc, cfg-path-version: path_exists -> accessible + talk about fields.
77bf1d6
@Centril
rfc, cfg-path-version: refresh start date.
8c9858a
@Centril
rfc, cfg-path-version: fix typo
09f23a8
@Centril
rfc, cfg-path-version: reword a bit
7ca8a5f
@Centril Centril added the T-lang Relevant to the language team, which will review and decide on the RFC. label Aug 12, 2018
@Centril Centril self-assigned this Aug 12, 2018
@Centril Centril changed the title RFC: #[cfg(accessible(..) / version(..) / nightly)] RFC: #[cfg(accessible(..) / version = ".." / nightly)] Aug 12, 2018
@Centril
Copy link
Contributor Author

Centril commented Aug 12, 2018

cc @MajorBreakfast re. use case for futures. :)

@rfcbot rfcbot added the finished-final-comment-period The final comment period is finished for this RFC. label Sep 22, 2019
@rfcbot
Copy link

rfcbot commented Sep 22, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot removed the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Sep 22, 2019
This was referenced Sep 26, 2019
Open
Open
@Centril Centril merged commit 7afbf18 into rust-lang:master Sep 26, 2019
@Centril
Copy link
Contributor Author

Centril commented Sep 26, 2019

🎉 Huzzah! This RFC has been merged! 🎉

Tracking issues:

@Centril Centril deleted the rfc/cfg-path-version branch September 26, 2019 02:36
@mathstuf mathstuf mentioned this pull request Sep 26, 2019
Closed
pickfire
pickfire reviewed Oct 3, 2019
View reviewed changes
@roblabla roblabla mentioned this pull request Oct 8, 2019
Open
@markbt markbt mentioned this pull request Jan 29, 2020
Merged
@pickfire pickfire mentioned this pull request Feb 23, 2020
Closed
@dennisschagt dennisschagt mentioned this pull request Jul 23, 2020
Merged
@taiki-e taiki-e mentioned this pull request Aug 25, 2020
Closed
@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Aug 23, 2022
Closed
@epage epage mentioned this pull request Sep 28, 2023
Closed
@kennytm kennytm mentioned this pull request Apr 9, 2024
Merged
@NimonSour NimonSour mentioned this pull request Aug 28, 2024
Closed
3 tasks
@epage epage mentioned this pull request Oct 26, 2024
Open
@epage epage mentioned this pull request Dec 17, 2024
Open
7 tasks
@epage epage mentioned this pull request May 16, 2025
Open
1 task
This was referenced May 17, 2025
Closed
Open
@est31 est31 mentioned this pull request May 30, 2025
Open
4 tasks
@tmandry tmandry mentioned this pull request Jun 17, 2025
Open
@traviscross traviscross mentioned this pull request Jul 7, 2025
Open
@traviscross traviscross mentioned this pull request Sep 24, 2025
Open
@clarfonthey clarfonthey mentioned this pull request Sep 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@joshtriplett joshtriplett joshtriplett left review comments

+9 more reviewers

@eddyb eddyb eddyb left review comments

@Nemo157 Nemo157 Nemo157 left review comments

@gnzlbg gnzlbg gnzlbg left review comments

@jethrogb jethrogb jethrogb left review comments

@Aaron1011 Aaron1011 Aaron1011 left review comments

@jrvidal jrvidal jrvidal left review comments

@XAMPPRocky XAMPPRocky XAMPPRocky left review comments

@pickfire pickfire pickfire left review comments

@rizakrko rizakrko rizakrko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@Centril Centril

Labels
A-cfg Conditional compilation related proposals & ideas A-paths Path related proposals & ideas A-versioning Versioning related proposals & ideas disposition-merge This RFC is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this RFC. T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.