Revert "Revert "Remove "edition" Cargo feature (it's stable now)""

[Xanewok]

Minus and minus equal plus, I guess 🤷‍♂️

[Xanewok]

continuous-integration/appveyor/branch i686

---- cmd_test_complete_self_crate_name stdout ----
thread 'cmd_test_complete_self_crate_name' panicked at 'Timed out waiting 30s for predicate', tests\support\mod.rs:160:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.
---rls-stdout---
Content-Length: 605
{"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-1712","rls.deglobImports-1712"]}}}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","title":"Building"}}Content-Length: 112
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library","title":"Building"}}Content-Length: 122
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library cfg(test)","title":"Building"}}Content-Length: 119
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"test cfg(test)","title":"Building"}}Content-Length: 104
{"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_1","title":"Building"}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_0","title":"Indexing"}}Content-Length: 364
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"","message":"expected identifier, found `~`\n\nexpected identifier","range":{"end":{"character":33,"line":2},"start":{"character":32,"line":2}},"severity":1,"source":"rustc"}],"uri":"file:///C:/projects/rls-x6grn/target/rlsit/t1/ws_with_test_dir/library/tests/test.rs"}}Content-Length: 104
{"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_0","title":"Indexing"}}Content-Length: 36
{"jsonrpc":"2.0","id":0,"result":[]}
---------------
failures:
    cmd_test_complete_self_crate_name
test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered ou

continuous-integration/appveyor/branch x86_64

---- cmd_test_complete_self_crate_name stdout ----
thread 'cmd_test_complete_self_crate_name' panicked at 'Timed out waiting 30s for predicate', tests\support\mod.rs:160:13
note: Run with `RUST_BACKTRACE=1` for a backtrace.
---rls-stdout---
Content-Length: 605
{"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-1520","rls.deglobImports-1520"]}}}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","title":"Building"}}Content-Length: 112
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library","title":"Building"}}Content-Length: 122
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library cfg(test)","title":"Building"}}Content-Length: 119
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"test cfg(test)","title":"Building"}}Content-Length: 104
{"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_1","title":"Building"}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_0","title":"Indexing"}}Content-Length: 364
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"","message":"expected identifier, found `~`\n\nexpected identifier","range":{"end":{"character":33,"line":2},"start":{"character":32,"line":2}},"severity":1,"source":"rustc"}],"uri":"file:///C:/projects/rls-x6grn/target/rlsit/t0/ws_with_test_dir/library/tests/test.rs"}}
---------------
---- cmd_changing_workspace_lib_retains_bin_diagnostics stdout ----
thread 'cmd_changing_workspace_lib_retains_bin_diagnostics' panicked at 'Timed out waiting 30s for predicate', tests\support\mod.rs:160:13
---rls-stdout---
Content-Length: 605
{"jsonrpc":"2.0","id":0,"result":{"capabilities":{"textDocumentSync":2,"hoverProvider":true,"completionProvider":{"resolveProvider":true,"triggerCharacters":[".",":"]},"definitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"workspaceSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{"resolveProvider":false},"documentFormattingProvider":true,"documentRangeFormattingProvider":false,"renameProvider":true,"executeCommandProvider":{"commands":["rls.applySuggestion-2692","rls.deglobImports-2692"]}}}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","title":"Building"}}Content-Length: 112
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library","title":"Building"}}Content-Length: 122
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"library cfg(test)","title":"Building"}}Content-Length: 111
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary","title":"Building"}}Content-Length: 121
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_1","message":"binary cfg(test)","title":"Building"}}Content-Length: 104
{"jsonrpc":"2.0","method":"window/progress","params":{"done":true,"id":"progress_1","title":"Building"}}Content-Length: 92
{"jsonrpc":"2.0","method":"window/progress","params":{"id":"progress_0","title":"Indexing"}}Content-Length: 680
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `unused`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_unused` instead: `_unused`","range":{"end":{"character":30,"line":2},"start":{"character":24,"line":2}},"severity":2,"source":"rustc"},{"code":"unused_variables","message":"unused variable: `test_val`\n\nhelp: consider using `_test_val` instead: `_test_val`","range":{"end":{"character":36,"line":9},"start":{"character":28,"line":9}},"severity":2,"source":"rustc"}],"uri":"file:///C:/projects/rls-x6grn/target/rlsit/t1/simple_workspace/library/src/lib.rs"}}Content-Length: 440
{"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"unused_variables","message":"unused variable: `val`\n\nnote: #[warn(unused_variables)] on by default\nhelp: consider using `_val` instead: `_val`","range":{"end":{"character":27,"line":4},"start":{"character":24,"line":4}},"severity":2,"source":"rustc"}],"uri":"file:///C:/projects/rls-x6grn/target/rlsit/t1/simple_workspace/binary/src/main.rs"}}
---------------
failures:
    cmd_changing_workspace_lib_retains_bin_diagnostics
    cmd_test_complete_self_crate_name
test result: FAILED. 2 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

At a first glance looks like it's spurious; redid /pr CI twice and looks green.
cc @alexheretic since it's a new 30s timeout. How long did these tests execute in your environment?

Merging since this is unrelated.

[alexheretic]

@Xanewok the 30s is waiting for indexing to finish after sending the requests, rather than for the entire test to run, so it should be plenty.

It could be that it's running very slowly and timedout, or that rls failed to return indexing-done for whatever reason. I think we could add time since rls-stdout which would help indicate if rls had stopped sending stuff before fail time.