This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Alternative attempt to support rangeLength field in LSP #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to fix the issue #280.
Since the pull request #281 ran into problems due to the fact that
rls-span
andrls-data
crates are actually used as API for interaction with Rust compiler, and have an embedded version of themselves inside it, changing them doesn't seem a good idea anymore.Hence this alternative less invasive approach, which touches only
rls
andrls-vfs
crates. Since it keeps usingrls-span 0.1
andrls-data 0.1
, it works and passes all tests locally, including fresh compilers, and so I expect Travis to confirm.I've reverted all changes in
rls-analysis
andrls-vfs
that were made in preparation of #281, as they're conflicting with this attempt, and further editedrls-vfs
to support this new way, which basically consists of addinglen
field to ReplaceText event ofrls
<->rls-vfs
interface.I will send PRs with those changes to the nrc repos, once Travis checks this build. Meanwhile, I've pointed
Cargo.toml
to my fixed repos, and you can see what's in them here.rust-dev-tools/rls-vfs@master...albel727:master
rust-dev-tools/rls-analysis@master...albel727:master
Luckily, changes to
rls-span
andrls-data
need not be reverted immediately, as they're depended upon not as git repos, but through crates.io. Let's leave the decision of what to do with them to nrc.