fix: clear diagnostics on cancel unconditionally, fixing #18854

davidbarsky · davidbarsky · commit 140f91b04503 · 2025-01-06T18:41:21.000-05:00
diff --git a/crates/rust-analyzer/src/flycheck.rs b/crates/rust-analyzer/src/flycheck.rs
@@ -419,9 +419,9 @@ impl FlycheckActor {
             command_handle.cancel();
             self.command_receiver.take();
             self.report_progress(Progress::DidCancel);
-            self.diagnostics_cleared_for.clear();
-            self.diagnostics_received = false;
         }
+        self.diagnostics_cleared_for.clear();
+        self.diagnostics_received = false;
     }
 
     /// Construct a `Command` object for checking the user's code. If the user

Original file line number	Diff line number	Diff line change
`@@ -419,9 +419,9 @@ impl FlycheckActor {`
`419`	`419`	`command_handle.cancel();`
`420`	`420`	`self.command_receiver.take();`
`421`	`421`	`self.report_progress(Progress::DidCancel);`
`422`		`- self.diagnostics_cleared_for.clear();`
`423`		`- self.diagnostics_received = false;`
`424`	`422`	`}`
	`423`	`+ self.diagnostics_cleared_for.clear();`
	`424`	`+ self.diagnostics_received = false;`
`425`	`425`	`}`
`426`	`426`
`427`	`427`	/// Construct a `Command` object for checking the user's code. If the user