Skip to content

Strange errors as if the extension forget to execute the linter #18854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mariogeiger opened this issue Jan 6, 2025 · 13 comments · Fixed by #18858
Closed

Strange errors as if the extension forget to execute the linter #18854

mariogeiger opened this issue Jan 6, 2025 · 13 comments · Fixed by #18858
Labels
C-bug Category: bug

Comments

@mariogeiger
Copy link

rust-analyzer version: rust-analyzer version: 0.4.2248-standalone (bfb8127 2025-01-06)

rustc version: rustc 1.83.0 (90b35a623 2024-11-26)

editor or extension: VSCode

code snippet to reproduce:

fn main() {
    println!("Hello, world!");
    let x = 5;
}
Image

I get errors that make no sense, it's like if the extension forgot the execute the linter.

@mariogeiger mariogeiger added the C-bug Category: bug label Jan 6, 2025
@manglemix

This comment has been minimized.

@fogodev

This comment has been minimized.

@ChayimFriedman2

This comment has been minimized.

@jmecinski

This comment has been minimized.

@seanhouli
Copy link

seanhouli commented Jan 6, 2025

manually downgrading the extension to 0.3.2237 fixed it.

@Veykril
Copy link
Member

Veykril commented Jan 6, 2025

Found the issue see https://github.com/rust-lang/rust-analyzer/pull/18848/files#r1904656621

Cant fix it right now though

@AldieNightStar

This comment has been minimized.

@Resonanz

This comment has been minimized.

@ChayimFriedman2
Copy link
Contributor

To everyone: This is fixed by #18858, and there will probably be another stable release tomorrow. Sorry for the breakage. In the meantime you can revert to an older version.

@ChayimFriedman2
Copy link
Contributor

@JoshLambda Sorry, I deleted your reply instead of replying to it. Here's my answer:

Good idea. Just let thousands of people get confused until tomorrow, instead of them seeing a fixed update pop in VS Code, that they could just apply right now.

I completely understand the frustration, but I cannot release a new rust-analyzer release. The keys are not in my hands. And @lnicola needs to sleep sometimes.

@JoshLambda
Copy link

JoshLambda commented Jan 7, 2025

The keys are not in my hands. And @lnicola needs to sleep sometimes.

Then I must apologize for directing my comment at you. So, it's a bigger issue related to the "bus factor", but it's probably off topic here.

@lnicola
Copy link
Member

lnicola commented Jan 7, 2025

The bus factor might be relevant in other cases, but all of the developers who've ever put up an out-of-band nightly release are in a European time zone. The bus only runs there.

@lnicola
Copy link
Member

lnicola commented Jan 7, 2025

This should now be fixed in v0.3.2253 (https://github.com/rust-lang/rust-analyzer/releases/tag/2025-01-07 on GitHub).

@rust-lang rust-lang locked as too heated and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-bug Category: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.