Skip to content

Fix up our pattern type inference and enable pattern type mismatch diagnostic #14250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue Mar 4, 2023 · 1 comment
Closed

Fix up our pattern type inference and enable pattern type mismatch diagnostic #14250

Veykril opened this issue Mar 4, 2023 · 1 comment
Labels
A-ty type system / type inference / traits / method resolution C-tracking-issue Category: tracking issue E-unknown It's unclear if the issue is E-hard or E-easy without digging in

Comments

@Veykril
Copy link
Member

Veykril commented Mar 4, 2023 •
edited
Loading

We are currently only reporting type mismatches for expressions, in an attempt to enable them for patterns I noticed we still have a bunch of mismatches in patterns. Let's fix that!

We seem to have 178 mismatches on the repo itself right now, https://rust-analyzer.github.io/metrics/.

Similar issue to #8961
@Veykril Veykril added E-unknown It's unclear if the issue is E-hard or E-easy without digging in A-ty type system / type inference / traits / method resolution C-enhancement Category: enhancement C-tracking-issue Category: tracking issue and removed C-enhancement Category: enhancement labels Mar 4, 2023
@HKalbasi
Copy link
Member

It did got fixed in #14732 and later PRs. We now have 0 mismatches on self, and the diagnostic is re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-ty type system / type inference / traits / method resolution C-tracking-issue Category: tracking issue E-unknown It's unclear if the issue is E-hard or E-easy without digging in
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Veykril @HKalbasi