Skip to content

Fix up our pattern type inference and enable pattern type mismatch diagnostic #14250

Closed
@Veykril

Description

@Veykril

We are currently only reporting type mismatches for expressions, in an attempt to enable them for patterns I noticed we still have a bunch of mismatches in patterns. Let's fix that!

We seem to have 178 mismatches on the repo itself right now, https://rust-analyzer.github.io/metrics/.

Similar issue to #8961

Activity

added
E-unknownIt's unclear if the issue is E-hard or E-easy without digging in
A-tytype system / type inference / traits / method resolution
and removed on Mar 4, 2023
HKalbasi

HKalbasi commented on Aug 26, 2023

@HKalbasi
Member

It did got fixed in #14732 and later PRs. We now have 0 mismatches on self, and the diagnostic is re-enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-tytype system / type inference / traits / method resolutionC-tracking-issueCategory: tracking issueE-unknownIt's unclear if the issue is E-hard or E-easy without digging in

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @Veykril@HKalbasi

        Issue actions

          Fix up our pattern type inference and enable pattern type mismatch diagnostic · Issue #14250 · rust-lang/rust-analyzer