Skip to content

r-a does not check the resourceOptions value reported by the client #14780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Veykril opened this issue May 11, 2023 · 1 comment · Fixed by #15101
Closed

r-a does not check the resourceOptions value reported by the client #14780

Veykril opened this issue May 11, 2023 · 1 comment · Fixed by #15101
Assignees
@alibektas
Labels
A-lsp LSP conformance issues and missing features C-bug Category: bug

Comments

@Veykril
Copy link
Member

Veykril commented May 11, 2023 •
edited by rustbot
Loading 

          It appears that this also affect Emacs' Eglot LSP client: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=63433

Originally posted by @mishazharov in #144 (comment)
@Veykril Veykril added C-bug Category: bug A-lsp LSP conformance issues and missing features labels May 11, 2023
@alibektas
Copy link
Member

@rustbot claim

@alibektas alibektas mentioned this issue Jun 21, 2023
Merged
bors added a commit that referenced this issue Jun 28, 2023
@bors
Auto merge of #15101 - alibektas:14780, r=Veykril
891331c 
Check Workspace Edit ResourceOps

PR fixes #14780
@bors bors closed this as completed in 1de842a Jun 28, 2023
HKalbasi pushed a commit to HKalbasi/rust-analyzer that referenced this issue Jun 29, 2023
@alibektas @HKalbasi
Check Workspace Edit ResourceOps
d149288 
Fixes rust-lang#14780 . This commit introduces guards for checking if the client supports ResourceOperations for operations to use them.
joshrotenberg pushed a commit to joshrotenberg/rust-analyzer that referenced this issue Jul 13, 2023
@alibektas @joshrotenberg
Check Workspace Edit ResourceOps
368db6c 
Fixes rust-lang#14780 . This commit introduces guards for checking if the client supports ResourceOperations for operations to use them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alibektas alibektas

Labels
A-lsp LSP conformance issues and missing features C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check Workspace Edit ResourceOps alibektas/rust-analyzer
2 participants
@Veykril @alibektas