'inline function' assist does not take as Self casts into account

[antonilol]

rust-analyzer version: 0.4.1765-standalone

rustc version: rustc 1.74.0 (79e9716c9 2023-11-13)

relevant settings: None

before:

struct MyStruct {
    number: usize,
}

impl MyStruct {
    fn new(number: usize) -> Self {
        Self { number } as Self
    }
}

// example 1
let s = MyStruct::new(123);

// example 2
let n = u64::from(123u32);

after (actual):

struct MyStruct {
    number: usize,
}

impl MyStruct {
    fn new(number: usize) -> Self {
        Self { number } as Self
    }
}

// example 1
let s = {
    let number = 123;
    MyStruct { number } as Self
};

// example 2
let n = {
    let small = 123u32;
    small as Self
};

after (expected):

struct MyStruct {
    number: usize,
}

impl MyStruct {
    fn new(number: usize) -> Self {
        Self { number } as Self
    }
}

// example 1
let s = {
    let number = 123;
    MyStruct { number } as MyStruct
};

// example 2
let n = {
    let small = 123u32;
    small as u64
};

Self should be changed to what the Self type was in the function (MyStruct or u64 here)

found after reporting #16090, might have the exact same fix but i have little experience here with the codebase

[roife]

I have submitted a PR that addressed this issue

[antonilol]

thanks, can confirm this is fixed